Add test for remote worker path resolution#97
Merged
furtib merged 7 commits intoEricsson:mainfrom May 1, 2026
Merged
Conversation
furtib
force-pushed
the
test-plist-resolution-regex
branch
from
d3dfa6b to
761121e
Compare
Szelethus
requested changes
Oct 13, 2025
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
I'm fine with creating/removing the tmp directory with a class level setup/teardown, but by having a global PATH_RESOLUTION, you practically do 90% of the test in those methods. In fact, I'm not even sure the way you are testing there is a need for creating any files. I recommend that you simply test the string replace, which is all that really matters here.
furtib
force-pushed
the
test-plist-resolution-regex
branch
from
bea98fe to
7d4745a
Compare
Szelethus
reviewed
Oct 15, 2025
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
Awesome, this is what I wanted to see! I have some nits, but otherwise this is a great PR.
furtib
force-pushed
the
test-plist-resolution-regex
branch
from
1a9a825 to
5d312a2
Compare
Szelethus
approved these changes
Apr 30, 2026
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
LGTM, though I believe pylint will catch this. Please rebase.
furtib
force-pushed
the
test-plist-resolution-regex
branch
from
5d312a2 to
d4ce1b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want to test our solutions for making remote workers' absolute paths into locally usable relative paths. We should add a test for it.
What:
Adds a new test to run on pre-created remote worker paths.
Addresses:
#65